Well, that’s a place I missed a semicolon. I missed the VTK_LEGACY_REPLACED_BODY calls that were split over 2 lines and didn’t see the error since buildbots build with LEGACY_REMOVE=ON.
That file just needs to die. https://gitlab.kitware.com/vtk/vtk/issues/17730
As for the pointer thing. The “attach to the variable” is a stupid C-ism. The pointer belongs to the type that is declared.
Is this something we can get clang-tidy to tell us about?