Well, my 2¢: I greatly prefer type* var.
I’m happy to see this formatting work, but personally I think it got merged way too fast. I first heard of it at the recent hackathon and it was merged just 7 business days later. For people like me that don’t work on VTK every day, that left no time to review it before.
Anyway… Now that this mega change has already occurred, I’d vote against another mega change of asterisk position.
There is this clang-tidy check:
https://clang.llvm.org/extra/clang-tidy/checks/readability-isolate-declaration.html
It seems to have done at least one weird thing to Objective-C++ code like:
https://gitlab.kitware.com/vtk/vtk/blob/master/Examples/GUI/Cocoa/MyWindowController.mm#L64
where -> got spaces added before and after. I couldn’t find any clang-format option related to this, but don’t know the tool well.
BTW is it normal that gitlab is not colouring Obj-C++ code at all?
Also, you might all find this interesting:
https://travisdowns.github.io/blog/2019/11/19/toupper.html
Sean