# Merge topic 'revert-shader-properties'

**URL:** https://discourse.vtk.org/t/merge-topic-revert-shader-properties/659
**Category:** Development
**Created:** [April 1, 2019, 9:26pm UTC](https://discourse.vtk.org/t/merge-topic-revert-shader-properties/659 "2019-04-01T21:26:12Z")
**Posts on this page:** 4
**Page:** 1

<div class="post-metadata">

### Author: ![amaclean](https://discourse.vtk.org/user_avatar/discourse.vtk.org/amaclean/32/224_2.png) [@amaclean](https://discourse.vtk.org/u/amaclean)
#### Post date: [April 1, 2019, 9:26pm UTC](https://discourse.vtk.org/t/merge-topic-revert-shader-properties/659/1 "2019-04-01T21:26:12Z")

</div>

Please consider using deprecation in future. I just had to revert a whole lot of changes to the VTKExamples.

Thanks  
Andrew

---

<div class="post-metadata">

### Author: ![ben.boeckel](https://discourse.vtk.org/letter_avatar_proxy/v4/letter/b/ea5d25/32.png) [@ben.boeckel](https://discourse.vtk.org/u/ben.boeckel)
#### Post date: [April 2, 2019, 12:43pm UTC](https://discourse.vtk.org/t/merge-topic-revert-shader-properties/659/2 "2019-04-02T12:43:13Z")

</div>

I reverted because it was merged too early, not that we wanted to deprecate the API usage. As explained in the MR for it, ParaView was breaking with it and in the interest of being able to continue on its release cycle, it was reverted until the underlying issue was fixed (efforts were made to avoid having to revert, but it wasn’t happening in a timely fashion). There’s now a diff which has the fix and it should be landing sooner rather than later.

---

<div class="post-metadata">

### Author: ![amaclean](https://discourse.vtk.org/user_avatar/discourse.vtk.org/amaclean/32/224_2.png) [@amaclean](https://discourse.vtk.org/u/amaclean)
#### Post date: [April 2, 2019, 9:30pm UTC](https://discourse.vtk.org/t/merge-topic-revert-shader-properties/659/3 "2019-04-02T21:30:36Z")

</div>

@ben.boeckel Thanks for that. I’ll save the changes I made. Please let me know when you put the fix in and I’ll make the changes to the VTKExamples.

---

<div class="post-metadata">

### Author: ![ben.boeckel](https://discourse.vtk.org/letter_avatar_proxy/v4/letter/b/ea5d25/32.png) [@ben.boeckel](https://discourse.vtk.org/u/ben.boeckel)
#### Post date: [April 3, 2019, 1:25pm UTC](https://discourse.vtk.org/t/merge-topic-revert-shader-properties/659/4 "2019-04-03T13:25:45Z")

</div>

The new MR is [here](https://gitlab.kitware.com/vtk/vtk/merge_requests/5354).
