(null);
let result: React.ReactNode;
useEffect(() => {
if (viewStream) {
// Unregister first to prevent duplicates
unregisterViewStream(viewStream);
// The register method does not check for existing viewStreams
registerViewStream(viewStream);
}
const setup = async () => {
if (
typeof window !== undefined &&
client &&
ref.current &&
!remoteView
) {
const session = client.getConnection().getSession();
const vtkRemoteView = await import(
"@kitware/vtk.js/Rendering/Misc/RemoteView"
);
const newView = vtkRemoteView.newInstance({
rpcWheelEvent: "viewport.mouse.zoom.wheel",
viewStream,
});
newView.setSession(session);
newView.setInteractiveRatio(0.9); // the scaled image compared to the clients view resolution
newView.setInteractiveQuality(70); // jpeg quality
newView.setContainer(ref.current);
newView.resize();
window.addEventListener("resize", newView.resize);
ref.current.addEventListener("resize", newView.resize);
setRemoteView(newView);
} else if (!client && remoteView) {
setRemoteView(null);
}
};
setup();
return () => {
if (viewStream) {
unregisterViewStream(viewStream);
}
};
}, [ref, client, remoteView, viewStream]);
if (client) {
result = (
);
}
return result;
}
);
RemoteViewer.displayName = "RemoteViewer";
```
---
### Author:  [@joaomlap](https://discourse.vtk.org/u/joaomlap)
#### Post date: [December 19, 2024, 11:47pm UTC](https://discourse.vtk.org/t/performance-drop-after-usage-wslink-vtk/15038/3 "2024-12-19T23:47:38Z")
I think it might be related to `vtkWebMouseHandler` and `vtkWebPublishImageDelivery` in VTK protocols.
I am not sure if this is the only problem or the one causing, but it seems that the `action` property on the event is always `down` which in turn creates a StartInteractionEvent multiple times before calling finally EndInteractionEvent.
I’ve noticed that `viewsInAnimation` does not get cleared as intended, or at least to my level of understanding. It seems that we push the same `viewId` over and over to the `viewsInAnimation` array until it gets cleared only 1 times on the end event.
This after some time from my understanding is causing degradation in the streaming protocol.
I am not 100% sure on how the code works so it could be on purpose but it seems like this is causing a leak which in turn forces more renderings than necessary.
---
### Author:  [@joaomlap](https://discourse.vtk.org/u/joaomlap)
#### Post date: [December 20, 2024, 12:24am UTC](https://discourse.vtk.org/t/performance-drop-after-usage-wslink-vtk/15038/4 "2024-12-20T00:24:57Z")
Again without knowing 100% of the code I think the `vtkRemoteView` with its interactorStyle `vtkInteractorStyleRemoteMouse` sends Start and End events correctly on it’s own, i.e. `StartInteractionEvent` and `EndInteractionEvent`. So it could be that without this bit:
```python
if event["action"] == "down":
self.getApplication().InvokeEvent("StartInteractionEvent")
if event["action"] == "up":
self.getApplication().InvokeEvent("EndInteractionEvent")
```
in
```python
class vtkWebMouseHandler(vtkWebProtocol):
@exportRpc("viewport.mouse.interaction")
def mouseInteraction(self, event):
```
is actually irrelevant and in this case causing the leak, but I’m not sure if it’s being used elsewhere, what I know here is that `action` is always `down` until it is `up` thanks to the way the interactor is created:
```javascript
function createRemoteEvent(callData) {
// Fields:
// - action: [down, up]
// - x, y (Normalized)
// Flags:
// - buttonLeft, buttonMiddle, buttonRight
// - shiftKey, ctrlKey, altKey, metaKey
const {
buttonLeft,
buttonMiddle,
buttonRight
} = model;
const shiftKey = callData.shiftKey ? 1 : 0;
const ctrlKey = callData.controlKey ? 1 : 0;
const altKey = callData.altKey ? 1 : 0;
const metaKey = callData.metaKey ? 1 : 0; // Might be platform specific
const action = buttonLeft || buttonMiddle || buttonRight ? 'down' : 'up';
// Fixme x / y
const [width, height] = model._interactor.getView().getSizeByReference();
let {
x,
y
} = callData.position;
x /= width;
y /= height;
return {
action,
x,
y,
buttonLeft,
buttonMiddle,
buttonRight,
shiftKey,
altKey,
ctrlKey,
metaKey,
...model.remoteEventAddOn
};
}
```
As we can see there action is always `down` or `up` causing the beforementioned problem.
---
### Author:  [@Sebastien\_Jourdain](https://discourse.vtk.org/u/Sebastien_Jourdain)
#### Post date: [December 20, 2024, 3:45am UTC](https://discourse.vtk.org/t/performance-drop-after-usage-wslink-vtk/15038/5 "2024-12-20T03:45:16Z")
Can you reproduce that issue in a small trame example? That might be easier to track down and fix.
---
### Author:  [@joaomlap](https://discourse.vtk.org/u/joaomlap)
#### Post date: [January 14, 2025, 10:53am UTC](https://discourse.vtk.org/t/performance-drop-after-usage-wslink-vtk/15038/6 "2025-01-14T10:53:37Z")
Hi Sebastien sorry for the long delay, I have been away.
So from my experiment this will happen on **any** VTK/WsLink project. If you create any sandbox project and put a debugger somewhere on the tracking views you will see that the list only gets bigger and bigger because all the events while mouse is down are characterised as DOWN and appending the view ID to tracking views.
---
### Author:  [@Sebastien\_Jourdain](https://discourse.vtk.org/u/Sebastien_Jourdain)
#### Post date: [January 15, 2025, 8:29pm UTC](https://discourse.vtk.org/t/performance-drop-after-usage-wslink-vtk/15038/7 "2025-01-15T20:29:31Z")
Can you make a small python example with trame and VTK that reproduce that behavior? Like I said, it will be easier for me to look at it and fix the issue.