Unnecessary VTK API change

[banesullivan]

@mwestphal

One of note from pyvista (@banesullivan ):

We wouldn’t blame you for being ruthlessly annoyed by the continual deprecation churn from Vtk. We kinda are. Like, seriously. Vtk, can you just slow down that moving API target a little there? face_exhaling

I want to clarify that I wasn’t the one who said that… Originally posted here: vtkThreshold::ThresholdByUpper was deprecated for VTK 9.1 and will be removed in a future version. · Issue #2850 · pyvista/pyvista · GitHub

@mwestphal

That being said, this should have been caught much earlier imo in order to avoid forcing VTK users to change their use of VTK.

Agreed!

[mwestphal (Mathieu Westphal (Kitware))]

@banesullivan

I want to clarify that I wasn’t the one who said that… Originally posted here:

Indeed unclear, I’ve edited my post to reflect that.

[lassoan (Andras Lasso)]

@mwestphal

@lassoan , it looks like @jcfr and yourself fixed that in slicer in June, what made you open this thread now and not at the time ? I’m just trying to understand what I did wrong here (apart misdjuging the usefulness of an API).

We changed most of the usages of the API, but there were some in Python that slipped our testing and found them months later, which forced us to create an urgent patch release.

The VTK API change looked small enough that we didn’t realize its actual impact at the time, but when it caused us this extra complication then we realized that it could cause trouble in many other VTK projects.