Yet another QVTKOpenGLWidget renaming ?

[mwestphal (Mathieu Westphal (Kitware))]

I agree. So let’s poll again :

• Use high-level naming, omiting “OpenGL” in the names, with the objective of using factories in the future.
• Use low-level naming, including “OpenGL” in the names, for clarity purpose.

please refrain to post until this poll is closed in two or three days.

[mwestphal (Mathieu Westphal (Kitware))]

Looks like it is quite even.

After discussing with @cory.quammen, I think the best would be to :

• Go forward with a low level rename of the widgets.
• Add a simple high-level named wrapper ready to be expanded once vulkan or other implementation are integrated and that can be used by applications, which points, for now, to QVTKOpenGLNativeWidget.

The only low-level rename proposition was then :

QVTKOpenGLNativeWidget -> QVTKOpenGLNativeWidget (no rename)
QVTKOpenGLWidget -> QVTKOpenGLStereoWidget

Let me know if there is a strong opposition to this suggestion.

[borisb (Boris Basic)]

@mwestphal

As some have remarked it, this suggest the the newly named QVTKOpenGLStereoWidget will never be adopted as a generic widget. I personally am fine with that. So difficulties present with it are inherent to it’s design and can’t be solved on our side, but only on Qt/GraphicDriverStack which we have no control of. As this design is not preferred by the Qt community, I’m not hopeful for these issues to be fixed.

It should also be noted that QVTKOpenGLNativeWidget has an issue when enabling multisampling, see https://gitlab.kitware.com/vtk/vtk/issues/17154. The problem seems to come from Qt as understood by @utkarshayachit (https://gitlab.kitware.com/vtk/vtk/issues/17154#note_546700). Because of this, I’m using mostly QVTKOpenGLWidget in my own applications, which does not suffer from this issue. So personally, I’m not particularly in favor of renaming this widget by adding a “Stereo” label to it, since I don’t use QVTKOpenGLWidget for its stereo capabilities at all. But I agree that for the other widget, the “Native” term is not very clear.

[mwestphal (Mathieu Westphal (Kitware))]

Here it is : https://gitlab.kitware.com/vtk/vtk/merge_requests/6506

[mwestphal (Mathieu Westphal (Kitware))]

The MR has been merged.