Hi @danlipsa,
Thanks for the comments!
- Do you need to duplicate Version in all blocks? I would rather add some code to propagate the Version from the parent and avoid the duplication.
I think you are right, we probably would not need the duplicate versioning in every block. We will update the design.
- Maybe choose a different name for Assembly to avoid confusion with vtkDataAssembly? Hierarchy maybe?
Our idea here was to indeed mirror the vtkDataAssembly since it actually corresponds to the information that is going to be included in the object. If this is still a blocking point however, we can rename the top level block.
- Are you going to have a different type for Multiblock and PartitionedDataSetCollection? Probably yes because the indexing scheme is different.
At this point, it is still relatively open. We can either have the root Type variable indicate the type one wishes as an output (either vtkPartitionedDataSetCollection or vtkMultiBlockDataSet) or we could accept a generic type name (such as Collection or Composite) and have the type be a property of the reader that we can switch dynamically. Do you have any preference for one or the other?