Julien Fausty:
- Do you need to duplicate Version in all blocks? I would rather add some code to propagate the Version from the parent and avoid the duplication.
I think you are right, we probably would not need the duplicate versioning in every block. We will update the design.
- Do you need to duplicate Version in all blocks? I would rather add some code to propagate the Version from the parent and avoid the duplication.
I do not think it’s a bad idea to have the version tag on all blocks. Do we completely rule out that the storage schemes for the Polydata, unstructured or image data ever change in the future?
Indeed the version can change. But the file will get the version of the current writer, and such there is only one version for the whole file.
With the original proposal, one could imagine having a composite dataset of Unstructured grids where each block has version 1.0, since that was the file format versio that included the unstructured grid description.
Once the unstructured grid was read in memory the version is not relevant anymore. That version is only the version for the VTKHDF storage.
Despite the entire file as a whole has version 3.0 (or whatever > 2.0). That indicate not just the type (polydata, unstructured, image) but also the storage layout version.
I also do not sew any gains in dropping it.
Why would it be useful or needed to want to write a file where different blocks are written with different versions of the format?
I think reducing complexity is generally beneficial unless there is a clear reason why we want to make things more complex.