Did VTK_CUSTOM_LIBRARY_SUFFIX build option go away?

Development
1

Hi all,

Did the VTK_CUSTOM_LIBRARY_SUFFIX option go away? I created a new folder and used cmake to configure VTK (git master), but even in ‘advanced mode’ I don’t see it there.

Cheers,

2

Yeah, I probably missed making this a public option. See the LIBRARY_NAME_SUFFIX argument to vtk_module_build at the top-level CMakeLists.txt. Should probably be something like:

set(VTK_CUSTOM_LIBRARY_SUFFIX "<DEFAULT>"
  CACHE STRING "Custom library suffix (defaults to ${VTK_MAJOR_VERSION}.${VTK_MINOR_VERSION}")
mark_as_advanced(VTK_CUSTOM_LIBRARY_SUFFIX)
if (VTK_CUSTOM_LIBRARY_SUFFIX STREQUAL "<DEFAULT>")
  set(VTK_CUSTOM_LIBRARY_SUFFIX "${VTK_MAJOR_VERSION}.${VTK_MINOR_VERSION}")
endif ()

Note that the default value shouldn’t be used in the cache variable literally otherwise version bumps don’t affect the already-cached value in an old build.

3

OK, here’s a patch:

https://gitlab.kitware.com/vtk/vtk/merge_requests/5166

Also, is it normal to get file names like below?:

libvtkChartsCore-8.90.8.90.0.a

After the patch above, I get names like:

libvtkChartsCore-8.90.a

so I think something else is adding these things twice.

Sean

4

I just noticed this today also, see: Version is repeated in the Linux library .so.0 files