json failures since 2020-01-02

Dashboards
1

Hi all,

I haven’t had time to look at VTK in weeks, and was sad to discover today several of my dashboards red since 2020-01-02:

https://open.cdash.org/index.php?project=VTK&date=2020-01-02

In file included from /Users/builder/external/VTK/ThirdParty/jsoncpp/vtkjsoncpp/jsoncpp.cpp:76:
/Users/builder/external/VTK/ThirdParty/jsoncpp/vtkjsoncpp/json/json.h:1240:32: error: inline declaration of 'as<bool>' follows non-inline definition
template <> inline bool Value::as<bool>() const { return asBool(); }
                               ^

My guess would be it’s from this?

commit 155aab854be2e3706605d59e773917abc4ae27d3
Merge: d653b75b9e 7104b4ac06
Author: Ben Boeckel <ben.boeckel@kitware.com>

    Merge branch 'upstream-jsoncpp' into HEAD
    
    * upstream-jsoncpp:
      jsoncpp 2019-12-30 (7d0e24cf)

Sean

2

We had discussed this here: https://gitlab.kitware.com/vtk/vtk/merge_requests/6340#note_675420

I’ll look at updating jsoncpp to include the upstream patch.

Cc: @utkarshayachit @will.schroeder @dgobbi

3

https://gitlab.kitware.com/vtk/vtk/merge_requests/6534