loguru link error on macOS 10.12

Hi all,

One, and only one, of my bots has this build error:

Undefined symbols for architecture x86_64:
  "vtkloguru::vstrprintf(char const*, __va_list_tag*)", referenced from:
      vtkLogger::LogScopeRAII::LogScopeRAII(vtkLogger::Verbosity, char const*, unsigned int, char const*, ...) in vtkLogger.cxx.o
      vtkLogger::LogScopeRAII::LogScopeRAII(vtkLogger::Verbosity, char const*, unsigned int, char const*, ...) in vtkLogger.cxx.o
      vtkLogger::LogF(vtkLogger::Verbosity, char const*, unsigned int, char const*, ...) in vtkLogger.cxx.o
      vtkLogger::StartScopeF(vtkLogger::Verbosity, char const*, char const*, unsigned int, char const*, ...) in vtkLogger.cxx.o

Not sure why it’s happening only on this bot… I investigated but could not figure it out… anyone have any thoughts?

Thanks,

Sean

The va_list impl is only implemented if !LOGURU_USE_FMTLIB, so I suspect the header needs to reflect this fact. I would guess that something is generating tooling (sanitizers?) on the method and when it doesn’t exist, things go poorly.

OK, it’s fixed. Amazingly, it was caused by some unsupported warning flags, specifically:

-Wno-unused-template -Wno-shadow-field -Wno-return-std-move-in-c++11

that were leftover from a compiler version change. Really surprising to me that it could have this effect.

Sean