WSLink launcher is not deleting services

aji · December 19, 2022, 10:08am

WSLink launcher is not deleting services. There is bug in code in following file

Kitware/wslink/blob/master/python/src/wslink/backends/aiohttp/launcher.py

import argparse
import asyncio
import datetime
import io
import json
import logging
import os
import re
import string
import subprocess
import sys
import time
import uuid

from random import choice

import aiohttp.web as aiohttp_web

from . import _root_handler

This file has been truncated. show original

web_app.add_routes(
    [
        aiohttp_web.post(endpoint, launcher_resource.handle_post),
        aiohttp_web.get(endpoint+'{id}', launcher_resource.handle_get),
        aiohttp_web.delete(endpoint+'{id}', launcher_resource.handle_delete),
    ]
)

+‘{id}’ part is missing in get and delete. After the above change service deletion is working fine. Kindly look in to it.

Sebastien_Jourdain · December 19, 2022, 9:14pm

wslink==1.9.3 should fix that issue. Thanks for reporting it.

Although, I think I want to make those endpoint optional since they can pause a security concern.

Sebastien_Jourdain · December 20, 2022, 12:46am

In 1.10.0, I’ve made those endpoint optional. You can look at the README how to enable them using environment variables.

aji · December 20, 2022, 4:51am

Thanks a lot