Hi Community, With VTK-9 coming, I wonder if we should rename QVTKOpenGLWidget again, as the new version was not so much used after all as it has some specific failings, while it’s only advantage is to support stereo rendering. I suggest then the following renaming : QVTKOpenGLNativeWidget -> QVT…

[image] utkarshayachit: If we can think of a new name other than QVTKOpenGLWidget to avoid confusion with old name that’d be great, but not required. Not to stir up any long discussions, but how about vtkQWidget? I always found the QVTK prefix a little off from normal VTK class naming. May b…

[image] estan: I always found the QVTK prefix a little off from normal VTK class naming. The reasoning behind the QVTK prefix was that it indicated to the user/developer that it is a QObject subclass. Also, the API style would follow Qt’s rather than VTK’s, thus methods named with lowerCase e…

QVTKOpenGLWidget sounds good, but usually the “OpenGL” word is not included in class names that users should normally use (only in low-level implementation classes). So, QVTKWidget, QVTKRenderWidget, QVTKRenderWindowWidget names would be somewhat more appropriate.

[image] utkarshayachit: The reasoning behind the QVTK prefix was that it indicated to the user/developer that it is a QObject subclass. Also, the API style would follow Qt’s rather than VTK’s, thus methods named with lowerCase etc etc. Yep, I understand the logic. vtk* ==> typically inherits v…

The OpenGL part is here to not confuse with the old QVTKWidget that as not been removed yet. Maybe it is time to remove it, but we can’t use this name either. Also, let’s not use the WIndow term, as it is heavily charged in Qt. For QVTKOpenGLWidget : QVTKStereoWidget QVTKStereoRenderWidget QVTK…

Let’s make a poll for this to make it easier to summarize the results: For QVTKOpenGLWidget: poll For QVTKOpenGLNativeWidget: poll

(damn, discourse is awesome :slight_smile: )

Since we derive from QOpenGLWidget, we should definitely keep OpenGL in the name. At some point, I expect that we will have an OpenGL and a Vulkan rendering backend and we will have difficulty to differentiate them without OpenGL and Vulkan prefixes.

[image] Michael: Since we derive from QOpenGLWidget , we should definitely keep OpenGL in the name. At some point, I expect that we will have an OpenGL and a Vulkan rendering backend and we will have difficulty to differentiate them without OpenGL and Vulkan prefixes. +1 At some point we co…

[image] cory.quammen: QVTKStereoOpenGLWidget and QVTKOpenGLWidget Same for me, those 2 names are simple and clear, I don’t like the other propositions

VTK

Yet another QVTKOpenGLWidget renaming ?

Development

show post in topic

Home
Categories
Guidelines
Terms of Service
Privacy Policy

Powered by Discourse, best viewed with JavaScript enabled