building with gcc 10.1.0

Support
1

Hey, gcc 10.1.0 is released recently. Does anyone try to build vtk with gcc 10? I got something error like this:

make[2]: Entering directory '/build/vtk-git/src/build-vtk-git'
[ 44%] Building CXX object CMakeFiles/vtkImagingColorPython.dir/CMakeFiles/vtkImagingColorPython/vtkImageHSIToRGBPython.cxx.o
In file included from /build/vtk-git/src/vtk/Remote/PoissonReconstruction/MarchingCubes.h:37,
                 from /build/vtk-git/src/vtk/Remote/PoissonReconstruction/MarchingCubes.cpp:34:
/build/vtk-git/src/vtk/Remote/PoissonReconstruction/Geometry.h:245:3: error: ‘FILE’ does not name a type
  245 |   FILE *oocPointFile, *triangleFile;
      |   ^~~~
/build/vtk-git/src/vtk/Remote/PoissonReconstruction/Geometry.h:39:1: note: ‘FILE’ is defined in header ‘<cstdio>’; did you forget to ‘#include <cstdio>’?
   38 | #include "Hash.h"
  +++ |+#include <cstdio>
   39 | 
make[2]: Entering directory '/build/vtk-git/src/build-vtk-git'
make[2]: *** [Remote/PoissonReconstruction/CMakeFiles/PoissonReconstruction.dir/build.make:96: Remote/PoissonReconstruction/CMakeFiles/PoissonReconstruction.dir/MarchingCubes.cpp.o] Error 1
make[2]: Leaving directory '/build/vtk-git/src/build-vtk-git'
make[1]: *** [CMakeFiles/Makefile2:20415: Remote/PoissonReconstruction/CMakeFiles/PoissonReconstruction.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

It seems that vtk/Remote/PoissonReconstruction/Geometry.h did not include cstdio. I didn’t get this error when I use gcc 9, not sure why.

2

The remote modules are not VTK code exactly. Upstream for it is at https://github.com/lorensen/PoissonReconstruction. Though since Bill is no longer with us, I think we may need a new home for this. @amaclean Do you have rights to that repo? If not, we’ll need someone to take up its cause.

3

I probably don’t. There has been very little activity on it since around 2011. It was forked from David Doria’s repository of the same name.

4

Oh, it’s a remote module. I think I could disable it.

5

Disabling it would be the best approach.

6

Not sure if the maintainer has disabled the module but we have it building in CI on Fedora, but have not done an official build yet.

https://src.fedoraproject.org/rpms/vtk/pull-request/1

7

Koji doesn’t allow network access, so I imagine that’s likely the cause there.