So I’ve just done a bit of triage on my vtk cdash submissions and there are lots of new errors & warnings there that should be fixed. It would take me most of a day to git blame every one of them and contact the person that introduced the issue. Nonetheless, I did this for errors (but not warnings).
I have 2 more concrete suggestions for improving this situation:
Increase the warning settings that the gitlab buildbots use. For macOS, I have very fine grained warning settings that I can share. I guess with @ben.boeckel ? If you tell me the Xcode versions of your bots, I can give you corresponding warning flags.
Figure out why 3rd party lib warnings appear on cdash. I thought there was already a mechanism to remove such warnings, yet I see hdf5 warnings here for example:
I’d like to see additional warning flags gated behind a CMake option so that developers can easily enable them as well. CI can then just flip that flag in .gitlab/ci/configure_common.cmake. See CMake/vtkSanitize.cmake and CMake/vtkSanitizeFlags.cmake (separated so that some of the setup logic is not affected).
Are you doing ctest_read_custom_files("${CTEST_BINARY_DIRECTORY}") in your CTest script? These suppressions come from CMake/CTestCustom.cmake.in which is configured into the build tree.
Are you doing ctest_read_custom_files("${CTEST_BINARY_DIRECTORY}") in
your CTest script? These suppressions come from CMake/ CTestCustom.cmake.in which is configured into the build tree.
I see ctest_read_custom_files(${CTEST_BINARY_DIRECTORY}) in vtk_common.cmake, which I include. Maybe you could take a look here: